SpiSlaveSpecifier class name should be refactored.

suikan4github / murasaki

STM32 HAL class library

MIT License

18 stars 3 forks source link

SpiSlaveSpecifier class name should be refactored. #24

Closed suikan4github closed 5 years ago

suikan4github commented 5 years ago

https://github.com/suikan4github/murasaki/blob/master/Inc/spislavespecifier.hpp

Is your feature request related to a problem? Please describe. The SpiSlaveSpecifier class is actually belonging to the adapter pattern. So the specifier is a bad name. It must confuse the customer.

Describe the solution you'd like The SpiSlaveSpecifier should be renamed as SpiSlaveAdatper.

suikan4github commented 5 years ago

Probably SpiSpecSpecifierStrategy -> SpiSpecAdapterStrategy SpiSpecSpecifier -> SpiSpecAdapter

suikan4github commented 5 years ago

merged to develop. ready to release