Closed kentakayama closed 9 months ago
Hi @kentakayama,
I understand your comment and your objective is good, but I feel the changes are a bit too intrusive considering it is at the last stage of the suit-firmware-encryption draft.
@mcd500 Exactly but my concern was arised after the suit-mti document defines profiles using AES-CTR. Additionaly, I realized that there is a mismatch around ECDH-ES+HKDF.
My concern is that some might create a manifest like:
directive-override-parameters {
uri: "http://example.com/file.bin",
encryption-info: <<96([h'', { / alg / 1: -65534 / A128CTR / }, null, ... ])>>
},
directive-fetch,
directive-copy / decrypt fetched payload using encryption-info /
/ done /
The manifest processor would decrypt the payload without checking its integrity because the AES-CTR protects only confidentiality. The condition-image-match SHOULD be executed on plaintext payload after decryption (or on cipheitext payload before decryption, see section 7 in detail). But it MAY be skipped when the code signing and secure boot protect the plaintext payload. On the other hand as long as we use AEAD such as AES-GCM, condition-image-match is not required after decryption because its tag are validated at the same time.
I think they are so complicated and the non AEAD might be easily misused. That's why I've raised this issue.
There are a lot of security mechanisms in both SUIT Manifest document and this document. Avoiding them to be misused, how about adding a guidance for selecting mechanisms and reconstruct the chapter?
Chapter Reconstruction
8.1. Security Mechanisms
8.2. Payload Delivery
8.3. Mechanism Patterns for Best Practice