search

suitcss / base

CSS base styles for web apps (a thin layer on top of normalize.css)
http://suitcss.github.io/base/test/
MIT License
194 stars 24 forks source link

Add `repository` field to `package.json` #12

Closed alrra closed 10 years ago

alrra commented 10 years ago

Prevent npm from showing the No repository field warning.

@necolas I didn't wanted to basically "spam" you with these types of pull requests, but I think you should add the repository field in the package.json file of all components. Even if the warnings are harmless, having multiple components, will just make the them pile up, either annoying or confusing the user.

necolas commented 10 years ago

i thought npm was meant to have fixed this

alrra commented 10 years ago

i thought npm was meant to have fixed this

@necolas they did, for repositories marked as private, but AFAIK, this warning isn't going to be removed.

Also, if it is of any importance, I'm using the latest npm version (currently v1.4.10)

alrra commented 10 years ago

i thought npm was meant to have fixed this

@necolas since my previous comment, a new issue was created: https://github.com/npm/npm/issues/5253.

sindresorhus commented 10 years ago

Regardless of the warning it's annoying when a package don't have a repository set and you can't click to get to the repo directly from npmjs.org.