search

suitcss / base

CSS base styles for web apps (a thin layer on top of normalize.css)
http://suitcss.github.io/base/test/
MIT License
194 stars 24 forks source link

Update normalize.css to 4.0.0 #31

Closed oskarrough closed 8 years ago

oskarrough commented 8 years ago

This updates normalize to the 4.0.0 release.

AntonTrollback commented 8 years ago

Wait for 4.0.1? Looks like they have a few changes on the way

simonsmith commented 8 years ago

Yeah? Can maybe merge this then and publish whenever the patch appears

giuseppeg commented 8 years ago

We need to patch base.css afaik there is at least one thing to fix that is removing the reset for input[type="search"].

Also this has to be a major release.

AntonTrollback commented 8 years ago

Can be removed from Button:

.Button::-moz-focus-inner {
  border: 0;
  padding: 0;
}
simonsmith commented 8 years ago

Agreed about testing. I can look over the test page in Browserstack

simonsmith commented 8 years ago

Closed in favour of https://github.com/suitcss/base/pull/32

@oskarrough Added your commit to the new PR so I could add some additional changes

oskarrough commented 8 years ago

Thanks! On Thu, 7 Apr 2016 at 20:09 Simon Smith notifications@github.com wrote:

Closed #31 https://github.com/suitcss/base/pull/31.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/suitcss/base/pull/31#event-618906961