Duplication of rules - Githubissues

suitcss / base

CSS base styles for web apps (a thin layer on top of normalize.css)

http://suitcss.github.io/base/test/

MIT License

194 stars 24 forks source link

Duplication of rules #39

Closed kristoforsalmin closed 7 years ago

kristoforsalmin commented 7 years ago

Hi there,

I noticed that the latest release has two fieldset rules in lib/base.scss:

https://github.com/suitcss/base/blob/master/lib/base.css#L59-L63
https://github.com/suitcss/base/blob/master/lib/base.css#L114-L118

I don't know which one is correct, but it seems like setting some actual styling on fieldset should be on normalize.css' shoulders.

Any thoughts?

Thanks!

kristoforsalmin commented 7 years ago

I guess, it's sort of related https://github.com/necolas/normalize.css/blob/master/normalize.css#L311-L313.

simonsmith commented 7 years ago

Good catch. Looks like a leftover from when a bunch of defaults were taken out of normalize in 6.0.0. Seeing as it's all been reverted in 7.0.0 we can remove all those rules again.

Essentially undoing some of #38

simonsmith commented 7 years ago

Fixed in 4.0.0