search

suitcss / preprocessor

A future-facing CSS preprocessor (used by SUIT CSS)
http://suitcss.github.io
MIT License
135 stars 25 forks source link

Bump stylelint version to 7 #32

Closed giuseppeg closed 8 years ago

giuseppeg commented 8 years ago

Tests are failing mysteriously. It seems that autoprefixer is not adding display: -webkit-flex; @simonsmith any idea?

giuseppeg commented 8 years ago

also I am afraid that they don't support node 0.12.0 anymore. Do we care? Should we just support 4 to 6?

simonsmith commented 8 years ago

Might be that webkit-flex has dropped off the browserslist last two versions. If so then I think we can update the test safely.

And yeah, let's just support 4 and 6

giuseppeg commented 8 years ago
Might be that webkit-flex has dropped off the browserslist last two versions.

How can you tell? I mean does it happen magically? If so should we pin our dependencies or use shrinkwrap?

simonsmith commented 8 years ago

It happens based on the caniuse database which is what powers browserslist (and eventually autoprefixer). Looking at the flex page it seems as though the latest 9.1 release of Safari has meant it's now three versions back so it drops off.

This is how it's supposed to work and I kind of like this approach, but there is nothing to stop us specifying our own browserslist config if we think it's too soon. Users can also add their own if they have specific reasons to keep older browsers supported.

The default is > 1%, last 2 versions, Firefox ESR

Regardless we could either update the test fixture, or add a test only browserslist config to pin it to some browser versions.

giuseppeg commented 8 years ago

@simonsmith I tend to agree with you that "this is how it's supposed to work". However if I learnt something from working at a corporate is that you don't want surprises.

However2 I don't care about legacy so I'd say let's fix the test but maybe we should talk about using shrinkwrap.

simonsmith commented 8 years ago

I think a browserslist config would be a better route if we wanted to pin the support for prefixes. Perhaps better than that is to revise the SUIT browser list and let that drive the config file. Then we can specify browser versions and only remove them when we choose.

Additionally a note on the README about declaring your own config might be useful as many devs don't realise it works this way and it could catch them out.