mergeOptions shouldn't override postcss-import's transform

suitcss / preprocessor

A future-facing CSS preprocessor (used by SUIT CSS)

http://suitcss.github.io

MIT License

135 stars 25 forks source link

Closed giuseppeg closed 8 years ago

giuseppeg commented 8 years ago

In mergeOptions we override postcss-import's transform method.

We should instead wrap it and combine it with lintImportedFiles.

As I said on gitter beforeLint is a special case of transform so we might as well fix #35 in this branch.

simonsmith commented 8 years ago

Noticed we're also overriding onImport too

giuseppeg commented 8 years ago

Good catch @simonsmith I can work on this when #35 is merged

simonsmith commented 8 years ago

So, I'm kinda half way through because I started beforeLint removal and noticed this issue said might as well do both at once.

giuseppeg commented 8 years ago

No worries, better if we keep the branches small.

simonsmith commented 8 years ago

Yeah, I can push the beforeLint stuff now. Keep the PRs focussed