suitcss / suit

Style tools for UI components
http://suitcss.github.io/
3.8k stars 229 forks source link

Correct style of multi-line declaration #124

Closed jeddy3 closed 8 years ago

jeddy3 commented 8 years ago

Oops, my bad. I got the style of the multi-line declaration wrong in my last PR.

I only realised my mistake while testing the upcoming release of stylelint-config-suitcss.

The repeating-linear-gradient declaration should match the style of the box-shadowone i.e. with a newline after the colon:

.selector {
  background-image:
    repeating-linear-gradient(
      -45deg,
      transparent,
      transparent 25px,
      rgba(255, 255, 255, 1) 25px,
      rgba(255, 255, 255, 1) 50px
    );
  box-shadow:
    1px 1px 1px #000,
    2px 2px 1px 1px #ccc inset;
}

Sorry about that...

simonsmith commented 8 years ago

Nice, thanks for the fix

jeddy3 commented 8 years ago

Thanks for merging! :)

FYI, I've just released stylelint-config-suitcss 1.0.0, which I think checks for everything in the STYLE.md file, including the stuff in the "Exceptions and slight deviations" section.

Good luck with the migration to PostCSS and, like I said previously, please don't hesitate to give me a holler if you stumble into any issues when adding in stylelint or stylelint-config-suitcss.

simonsmith commented 8 years ago

Great, will be sure to notify you if there are any issues. Thanks.