Closed mlnmln closed 5 years ago
@giuseppeg Thanks for the feedback, I added my points.
My main goal now, would be to have a shared understanding of scope / task breakdown.
This PR allows publishing new versions for each package through lerna.js, (hopefully) without breaking anything.
I would strongly recommend splitting any other features (shared test runner, travis config etc., ) into separate issues, unless you think they are critical for landing the PR.
Otherwise we can work on this indefinitely.
I think this looks good!
This PR is limited in scope intentionally and should be a good foundation for further development work with a monorepo approach.
I agree with this. This work will give us the push to get carry on with other outstanding issues and we can refine the lerna setup as we go.
Great stuff @mlnmln.
One question regarding the root level package.json
. If we were to bump and publish say, suitcss-base
do we then need to bump the version in the root package.json and publish the suit
package?
@simonsmith
I agree with this. This work will give us the push to get carry on with other outstanding issues and we can refine the lerna setup as we go.
Glad to hear.
One question regarding the root level package.json. If we were to bump and publish say, suitcss-base do we then need to bump the version in the root package.json and publish the suit package?
For as long as we use independent
versioning, I don't think so, no.
We would only bump the suit
package when we want it to use a new version of suitcss-base
outside its current caret range.
But to have that more clearly separated I think we should take action on https://github.com/suitcss/suit/pull/153#discussion_r245634938
Then we essentially would have a (private) root
package that is not suit
.
SEE: https://github.com/babel/babel/blob/master/package.json#L3
That package then would take care of shared dev dependencies etc in the long run, but is not installable on its own via npm.
It relatively easy and I could do it during the next couple of days. What do you think?
But to have that more clearly separated I think we should take action on #153 (comment)
That seems a logical approach to me, yes
@simonsmith @giuseppeg
In the midterm this should be split into a project and a package readme for the suit package only.
@mlnmln I guess that for now we can duplicate it
@mlnmln I guess that for now we can duplicate it
works for me.
@simonsmith I just pushed a pre-monorepo
branch to save a copy of the status quo. Feel free to merge when you've taken a look at the PR.
@mlnmln thank you a lot for your help and patience :)
Looks great to me. Merging
@simonsmith @giuseppeg
nsp
(bc of reported security issue,lerna bootstrap
would not finish otherwise).repo
,homepage
andbugs
in all packages.Use
lerna bootstrap
to install all packagesTo test lerna versioning
lerna version patch --yes --no-push
to test locally before doing anything on remote.To publish
npm login
, thenlerna publish patch --yes
This results in the following version bumps, everything should stay 100% backwards compatible.
This PR is limited in scope intentionally and should be a good foundation for further development work with a monorepo approach.
151