search

suitepad-gmbh / pipette

Flow-Based Programming framework for Elixir
MIT License
21 stars 3 forks source link

Feat/client accept ip #10

Closed spieker closed 6 years ago

spieker commented 6 years ago

I've a pretty bad internet connection at the moment and the NYCBikeShares test is not running. Don't know if it's a bug in the implementation or my bad connection. Anyways, we should use cassettes, to not make actual requests in tests.

I'm going to check the tests tomorrow in the office again.

spieker commented 6 years ago

@Overbryd I like you changes. They're merged back into this PR. The commits are rebased, so we keep a clean history.

I've run the tests again, and as expected, the NYCBikeShares test works in the office (reliable network [more or less 😜])

Overbryd commented 6 years ago

Its about time to move the examples to their own /example folder.

:)

Paul Spieker notifications@github.com schrieb am Do. 28. Juni 2018 um 08:12:

@Overbryd https://github.com/Overbryd I like you changes. They're merged back into this PR. The commits are rebased, so we keep a clean history.

I've run the tests again, and as expected, the NYCBikeShares test works in the office (reliable network [more or less 😜])

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/suitepad-gmbh/pipette/pull/10#issuecomment-400922712, or mute the thread https://github.com/notifications/unsubscribe-auth/AABSdxKiJSf8rlym5sMKure0YkLoih7Pks5uBHO9gaJpZM4U5s1n .