search

sujithkanna / SmileyRating

SmileyRating is a simple rating bar for android. It displays animated smileys as rating icon.
Apache License 2.0
1.08k stars 185 forks source link

Fix issue #24 #25

Closed addisonElliott closed 7 years ago

addisonElliott commented 7 years ago

Bug where clicking on terrible smiley the first time would result in it being colored normally instead of angry color.

When the previous selected state or new selected state of a smiley is NONE, then things are handled differently since there is no previous or next state to translate to. Instead, the background color is faded from deselected to selected. However, it was hardcoded to fade to normal color when there should be a check if the previous or next selected state and set to angry color if so.

sujithkanna commented 7 years ago

Thank you very much for the fix :) and please ignore the build failed message in your request, I haven't configured the Travis properly. False alarm(My fault). Now I have merged your pull request for issues #22 and #24. Kindly keep contributing to make this better :)