search

sujithsomraaj / lifi-emergency-pause-facet-v1.2.0

1 day review - 1 / 09
0 stars 0 forks source link

Index event parameters #5

Open sujithsomraaj opened 2 months ago

sujithsomraaj commented 2 months ago

Context: EmergencyPauseFacet.sol#L19-L21

Description: The events EmergencyFacetRemoved, EmergencyPaused, and EmergencyUnpaused lacks the indexed keyword for their parameters. Indexing event parameters improves off-chain tracking.

Recommendation: Add indexed keyword to event params

LI.FI: Fixed in 111a2e4f6e7986a2d4c56f95524eec76796e8beb

Researcher: Confirmed

0xDEnYO commented 2 months ago

Fix: https://github.com/lifinance/contracts/commit/111a2e4f6e7986a2d4c56f95524eec76796e8beb