search

sujithsomraaj / lifi-stargate-v2-audit

3 Day Review [10 Jun 2024 - 13 Jun 2024]
0 stars 0 forks source link

`lzCompose` function in `ReceiverStargateV2` misses `override` keyword #8

Open sujithsomraaj opened 5 months ago

sujithsomraaj commented 5 months ago

Context: ReceiverStargateV2.sol#L83

Description: The function lzCompose in ReceiverStargateV2 overrides the implementation in ILayerZeroComposer, which the later contract imports. However, the function fails to add the override keyword.

Recommendation: Add the missing override keyword to improve code quality.

LI.FI:

Researcher:

0xDEnYO commented 5 months ago

Hi @sujithsomraaj ,

I think since Solidity v0.8.8 it is not required anymore to add override keyword if only one interface function is implemented: https://github.com/ethereum/solidity/releases/tag/v0.8.8 image

I would therefore vote to close this issue without further action.

0xDEnYO commented 5 months ago

@ezynda3 if you agree, could you please close this issue?

ezynda3 commented 5 months ago

I agree. Since it's not coming from an abstract contract and not really overriding any real logic we can omit the override I think.