search

sukeban / TwitterClient

An example Twitter client for the CodePath exercise #3
0 stars 0 forks source link

Hey @nesquena and @thecodepath my app is completed please review. #2

Open sukeban opened 9 years ago

sukeban commented 9 years ago

What do you think about my method for starting and stopping the ProgressBar? Is there a cleaner way to do this? Ideally the spinner would be round and over the list view, but when I tried to drag it in using the graphical editor, the ListView turned red and would not let me.

nesquena commented 9 years ago

:+1: Project looks good! Nice job getting in several optionals. I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.

nesquena commented 9 years ago

What do you think about my method for starting and stopping the ProgressBar? Is there a cleaner way to do this? Ideally the spinner would be round and over the list view, but when I tried to drag it in using the graphical editor, the ListView turned red and would not let me.

You can use a spinning progress bar in the "header" of the ListView as explained here as a simple way to do what you mentioned.