search

sukeesh / Jarvis

Personal Assistant for Linux and macOS
MIT License
2.99k stars 1.03k forks source link

fix: Ask user for column input again in connect_four instead of throwing error #1129

Closed nagxsan closed 1 year ago

nagxsan commented 1 year ago

Description

In the connect_four plug-in, if the user enters a non-numeric value as input for column, then an error is thrown to the user which interrupts the gameplay and stops it. Instead of throwing ValueError to the user, we can simply ask them again for the column input till they enter a numeric input.

Before

Screenshot 2023-08-26 200414

nagxsan commented 1 year ago

Here is the PR for the fix as stated above

nagxsan commented 1 year ago

@pnhofmann is this fine or should I change something here?