sukeesh / Jarvis

Personal Assistant for Linux and macOS
MIT License
2.99k stars 1.03k forks source link

Fix the cryptotracker plugin #1134

Closed niljub closed 11 months ago

niljub commented 1 year ago

Hello Jarvis Team,

I saw the cryptotracker stopped working, so I switched the defunct API and built a solution using Binance's API. This pull request aims to address the issue by implementing the following changes:

  1. API Replacement: I've replaced the outdated API with Binance's API.

  2. Code Refactoring: I have refactored the code to ensure it seamlessly integrates with Binance's API endpoints. This includes modifying the request and calling the data to match the new API structure.

  3. Switch to USDT: To address limitations I've made USDT (Tether) the default USD pairing for the cryptotracker. This change was necessary due to Binance not having any USD pairs.

pnhofmann commented 11 months ago

Thanks