sukeesh / Jarvis

Personal Assistant for Linux and macOS
MIT License
3.02k stars 1.04k forks source link

Enhancement to helper.py file #1217

Open leoscarlato opened 1 week ago

leoscarlato commented 1 week ago

When running the pylint command on the helper.py file, the tool indicated some changes that would make the code qaulity better:

***** Module helper installer\helper.py:49:0: C0301: Line too long (120/100) (line-too-long) installer\helper.py:130:0: W0301: Unnecessary semicolon (unnecessary-semicolon) installer\helper.py:163:0: C0301: Line too long (112/100) (line-too-long) installer\helper.py:1:0: C0114: Missing module docstring (missing-module-docstring) installer\helper.py:17:4: W0622: Redefining built-in 'input' (redefined-builtin) installer\helper.py:22:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:27:0: C0103: Constant name "debug_log" doesn't conform to UPPER_CASE naming style (invalid-name) installer\helper.py:30:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:31:4: W0603: Using the global statement (global-statement) installer\helper.py:33:10: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:32:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) installer\helper.py:36:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:40:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:49:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:56:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:60:11: W0718: Catching too general exception Exception (broad-exception-caught) installer\helper.py:69:15: W0718: Catching too general exception BaseException (broad-exception-caught) installer\helper.py:74:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:79:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:80:13: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:80:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:83:0: C0103: Constant name "spinning" doesn't conform to UPPER_CASE naming style (invalid-name) installer\helper.py:86:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:87:4: W0603: Using the global statement (global-statement) installer\helper.py:102:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:103:4: W0603: Using the global statement (global-statement) installer\helper.py:107:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:110:17: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:113:23: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:117:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:120:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) installer\helper.py:120:11: R1716: Simplify chained comparison between the operands (chained-comparison) installer\helper.py:121:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:124:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:126:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:130:19: R1719: The if expression can be replaced with 'test' (simplifiable-if-expression) installer\helper.py:131:8: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:131:61: C0121: Comparison 'confirm_bool == False' should be 'confirm_bool is False' if checking for the singleton value False, or 'not confirm_bool' if testing for falsiness (singleton-comparison) installer\helper.py:134:0: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:135:4: C0115: Missing class docstring (missing-class-docstring) installer\helper.py:136:8: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:139:8: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:143:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:166:8: W0201: Attribute 'exception' defined outside init (attribute-defined-outside-init) installer\helper.py:174:4: W0201: Attribute 'cli_output' defined outside init (attribute-defined-outside-init) installer\helper.py:145:4: C0115: Missing class docstring (missing-class-docstring) installer\helper.py:146:8: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:149:8: C0116: Missing function or method docstring (missing-function-docstring) installer\helper.py:174:4: W0201: Attribute 'cli_output' defined outside init (attribute-defined-outside-init) installer\helper.py:158:8: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:177:8: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) installer\helper.py:8:0: W0611: Unused IS_WIN imported from unix_windows (unused-import)


Your code has been rated at 6.29/10