search

sukima / ember-cli-select-picker

An enhanced Boostrap styled select component addon for Ember CLI
https://sukima.github.io/ember-cli-select-picker
MIT License
23 stars 15 forks source link

Set keyboard shortcuts scoped to select-picker #46

Closed sweco-secfha closed 8 years ago

sukima commented 8 years ago

I was having a discussion with a co-worker about this. We concluded the same problem was with mousetrap as you also did. I had no idea there was a scoped: true option available. And since then our plan was to remove the mousetrap dependency and instead rely on jQuery.which since jQuery is still a requirement for Ember at the moment so we know it will be there, doesn't rely on yet another library, and which normalizes the inconsistencies of keyboard events between browsers.

So I'm at a cross roads: continue using mousetrap or switch to jQuery. I think a point release with your fix and then another with jQuery. @tneems would you be willing to chime in?

Fixes issue #45

SCF-Builder commented 8 years ago

Sounds reasonable to me

sukima commented 8 years ago

Merged with a rebase. Closing.