search

sukovanej / effect-log

Log batteries for effect-ts
https://sukovanej.github.io/effect-log/
MIT License
25 stars 1 forks source link

Feature request: support for winston #18

Open jessekelly881 opened 1 year ago

jessekelly881 commented 1 year ago

Winston would be a useful addition to this set of loggers. Especially considering its support for and ecosystem of remote loggers like files, dbs, third party services like logtail,, etc. I would be willing to create a PR, but I'm wondering if there is interest in adding support for this to this lib or whether it might be better to make this a separate lib

jessekelly881 commented 1 year ago

I was playing with a solution here and it seems compact enough that it could probably be included in this lib as long as the dep is optional.

sukovanej commented 1 year ago

I don't really have a clear vision for this library. I created it solely to cover my use-cases for stdout local and non-local logging. At this point, I'd rather vote for a separate lib, honestly.

I use winston as well. I guess it's a pretty popular logging solution in general, thus it might be worth checking the effect-ts discord and maybe somebody already prepared a solution. If not, I'd be willing to convert this codebase into a monorepo and expose a package to simplify winston integration from here. Unfortunately, I can't really promise it'll happen in a near future.

jessekelly881 commented 1 year ago

Makes sense! I'll ask around. The logger I linked above satisfies my use case and I will probably just use that for the time being. Although, moving it to a lib(wherever that might be) would be helpful. Also, I'm sure there is a better way of implementing this than what I came up with. jaja