search

sukria / Backup-Manager

Versatile yet easy to use command line backup tool for GNU/Linux. Suitable for desktop and servers.
http://www.backup-manager.org/
GNU General Public License v2.0
279 stars 90 forks source link

Fixes for gettext make process and postgresql database backup method #16

Closed gzarkadas closed 12 years ago

gzarkadas commented 12 years ago

The gettext make fix ensures that 'make clean' returns the po/ subtree to its original status, something that will make the life of downstream packagers a lot easier (cf. the Debian case: http://anonscm.debian.org/gitweb/?p=collab-maint/backup-manager.git;a=blobdiff;f=debian/rules;h=0b8ffbafe6a96429648087f043db8ba707e0f6a1;hp=cbf3a530172f942f8389955fcb96585a65c82d23;hb=0f78250a538571df8a744993b9c6e7ec94ac8d85;hpb=f0c4f52c825e096dd4f833187376f403dc6ca5a5)

The pgsql backup method fixes solve a security issue (previous code did not check the permissions of .pgpass, in the case that already existed, before writing there the passwords) and enhance the robustness and features of the pgsql backup method in a couple of other areas. The last one is just a change on naming conventions, but it makes sense, especially if other database backends are going to be supported in the future.

Code has been tested on top of the 0.7.10.1 release, plus the patches for the next Debian version of the package (cf. http://anonscm.debian.org/gitweb/?p=collab-maint/backup-manager.git;a=log;h=refs/heads/build). For the pgsql method, I have broken the original debian patch to four subpatches with equivalent results, in order to ease the review.

kissifrot commented 12 years ago

Thanks! I'll review it ASAP ;)

Can you do it for the devel branch? It's the one which is preferred for a later release.

gzarkadas commented 12 years ago

Στις 25-12-2011, ημέρα Κυρ, και ώρα 04:01 -0800, ο/η Philippe Villiers έγραψε:

Thanks! I'll review it ASAP ;)

Can you do it for the devel branch? It's the one which is preferred for a later release.

Reply to this email directly or view it on GitHub: https://github.com/sukria/Backup-Manager/pull/16#issuecomment-3270587 Ok, I' ll start working on it.