search

sukria / Backup-Manager

Versatile yet easy to use command line backup tool for GNU/Linux. Suitable for desktop and servers.
http://www.backup-manager.org/
GNU General Public License v2.0
279 stars 90 forks source link

Devel: amend "single md5 sums file" patch #19

Closed gzarkadas closed 12 years ago

gzarkadas commented 12 years ago

This is a corrective commit to also handle md5 sum comparisons in burning methods the same way that is done in rest places. Without it the current (patched) implementation is broken in the sense that md5 comparisons in burning methods will fail.

I didn't had time to actually test it, because I do not burn cds/dvds anymore. However I believe it to be correct because the changes are concentrated in few lines of code. I plan to make burn tests later in spring, but didn't want to leave the issue unreported / unsolved till then.

The commit also drops calculation of md5 sum from the burned disk if not in database and issues a warning instead (since we cannot guarantee that a copy error did not occurred during burning if the original hash is missing, I find it more appropriate to warn; it also saves time).

I interleaved the last one to the main theme of the commit for convenience; the changed lines are very few anyway. If you do not like it that way I can split it to two separate commits in a topic branch instead.

gzarkadas commented 12 years ago

The second commit is independent of the first. It is a speed optimization I came across while fiddling with debian bug #612256.