sukria / Backup-Manager

Versatile yet easy to use command line backup tool for GNU/Linux. Suitable for desktop and servers.
http://www.backup-manager.org/
GNU General Public License v2.0
279 stars 90 forks source link

send_files_with_s3 just ignores the $repository argument #31

Closed huangjunyi closed 7 years ago

huangjunyi commented 11 years ago

I am checking the backup-manager-upload script from devel branch, finding out the send_files_with_s3 just ignores the $repository argument which causing the BM_UPLOAD_DESTINATION doesn't work for s3 upload method, is this expected?

I also noticed that

The bucket to upload to. This bucket must be dedicated to backup-manager export BM_UPLOAD_S3_DESTINATION=""

does "dedicated" imply the s3 upload method will take no destination / prefix?

In my opinion, I think it's very useful to specify a s3 key prefix in conf file so it allows backup-manager to share the bucket with other guys (by using different prefix).