search

sul-cidr / histonets

Histonets is an application to convert images of scanned maps into digital networks
https://histonets.stanford.edu
Other
20 stars 0 forks source link

[WIP] Use webpacker for react #204

Open csbailey5t opened 7 years ago

csbailey5t commented 7 years ago

Switch to using the webpacker gem to allow us to take advantage of benefits of modern js; refactor react and such to fit the new build process.

codecov-io commented 7 years ago

Codecov Report

Merging #204 into master will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   98.44%   98.39%   -0.05%     
==========================================
  Files          40       40              
  Lines         450      436      -14     
==========================================
- Hits          443      429      -14     
  Misses          7        7
Impacted Files Coverage Δ
app/models/histogram.rb 100% <0%> (ø) :arrow_up:
app/models/collection.rb 100% <0%> (ø) :arrow_up:
app/models/image.rb 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc4fd5f...814f1db. Read the comment docs.

mejackreed commented 7 years ago

When running locally in RAILS_ENV=production after precompiling the assets, I'm not able to get any assets to load in the application. Have you been able to get this going yet?

Also, where are we at with testing our deploy?

csbailey5t commented 7 years ago

@mejackreed I haven't tried it in the production env yet. We also don't have a deploy attempt yet for this. I suspect we'll need to hold on finishing this a bit and turn to other priorities for a while