[WIP] adds cropper and closes #52

sul-cidr / histonets

Histonets is an application to convert images of scanned maps into digital networks

https://histonets.stanford.edu

Other

20 stars 0 forks source link

[WIP] adds cropper and closes #52 #58

Closed aeschylus closed 7 years ago

aeschylus commented 7 years ago

How/where do I write a test for this?

codecov-io commented 7 years ago

Current coverage is 98.75% (diff: 100%)

Merging #58 into master will increase coverage by 0.03%

@@             master        #58   diff @@
==========================================
  Files            25         24     -1   
  Lines           156        160     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            154        158     +4   
  Misses            2          2          
  Partials          0          0

Powered by Codecov. Last update 548916b...23490c8

mejackreed commented 7 years ago

@aeschylus would you like to pair on writing the tests for this today?

aeschylus commented 7 years ago

@mejackreed that would be helpful for me.

csbailey5t commented 7 years ago

@aeschylus and @mejackreed Is this PR waiting for tests and style fixes before being considered for merging?

mejackreed commented 7 years ago

Yep, I'm going to throw a [WIP] (work in progress) tag on it. I think @aeschylus is redoing some aspects of it.

csbailey5t commented 7 years ago

Cool. I just pulled it to check it out and am running into a couple of issues. The image is not actually being shown within the cropper. Is that supposed to be the case at the moment? I'm also getting this error on the cropper page: Uncaught SyntaxError: Unexpected end of input crop_image:59, which might be why an image isn't being shown.

mejackreed commented 7 years ago

Yep we discussed that I think part of it was going to be reincorporated as a React component similar to the work done in the other component.

csbailey5t commented 7 years ago

This is now handled in #88