search

sul-cidr / histonets

Histonets is an application to convert images of scanned maps into digital networks
https://histonets.stanford.edu
Other
20 stars 0 forks source link

Add radio button to image clean form for posterize #68

Closed csbailey5t closed 7 years ago

csbailey5t commented 7 years ago

The form for posterize needs a radio button for selection the method for color reduction: kmeans or linear. Kmeans should be checked by default.

mejackreed commented 7 years ago

Great.. can we verify what the json for posterize should look like then?

csbailey5t commented 7 years ago

'[{"action":"posterize","options":{"colors":4, "method":"kmeans"}}]'

This worked for me by itself and with all the other actions in the json.

mejackreed commented 7 years ago

Great, and that color scale should be 0 -> 100?

csbailey5t commented 7 years ago

In the cli, it's an integer range from 2 to 128 due to algorithmic reasons. We could rescale if we need to.

mejackreed commented 7 years ago

ok. so that range should reflect that too I guess.

mejackreed commented 7 years ago

A prerequisite is a review and merge of https://github.com/sul-cidr/histonets/pull/70

csbailey5t commented 7 years ago

Per work this morning, the big question here is how to properly nest React components and share state as necessary.