sul-cidr / histonets

Histonets is an application to convert images of scanned maps into digital networks
https://histonets.stanford.edu
Other
20 stars 0 forks source link

convert all view copy to i18n for internationalization #72

Closed mejackreed closed 7 years ago

mejackreed commented 7 years ago

Closes #69

codecov-io commented 7 years ago

Current coverage is 98.73% (diff: 100%)

Merging #72 into master will increase coverage by 0.01%

@@             master        #72   diff @@
==========================================
  Files            25         25          
  Lines           156        158     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            154        156     +2   
  Misses            2          2          
  Partials          0          0          

Powered by Codecov. Last update 548916b...3c9deba

mejackreed commented 7 years ago

I'm not exactly sure what you mean. Could you post an example?

versae commented 7 years ago

Yep, I mean that instead of having things like

t('navigation.next_step')
t 'image_templates.title'

Which makes sense but is a bit cryptic and we might run out of names fast, we could have

t('Next Step')
t 'Create image templates'

And in the en.yml would be something like

en:
 - 'Next Step': 'Next Step'
 - 'Create Image Templates': 'Create Image Templates'

But not sure if this would work. I am just thinking out loud.

mejackreed commented 7 years ago

@versae yep that approach would work. I've only used the approach that I implemented (we use that in Blacklight/Hydra/GeoBlacklight), but am willing to change it up.

What do you think?

versae commented 7 years ago

No, that's OK, why change something that is proven to work, right? :)

mejackreed commented 7 years ago

/shrug.. i like your idea though