sul-cidr / noh

Noh as Intermedia
http://noh.stanford.edu/
MIT License
4 stars 2 forks source link

About submenu runs off-screen #483

Closed csbailey5t closed 5 years ago

csbailey5t commented 5 years ago

On internal pages, such as play or section level pages, the about dropdown menu can run off the right edge of the window

broadwell commented 5 years ago

Perhaps a fix for this would also address the more general tendency of the dropdown menus to overlap with the other headings -- the dropdown for INTERMEDIA often overlaps the P in PLAYS, the dropdown for PLAYS overlaps the E in ELEMENTS, etc.

simonwiles commented 5 years ago

It's not obvious to me what a solution to that would look like -- do you have ideas? More concerning to me (and much closer in terms of symptoms and possible solutions) is when the new "About" menu flows off the right-hand edge of the screen. Whatever is done to address this issue directly (and it looks to me like we're going to have to bite the bullet and script this behaviour), we should take this into account in the process, I think.

broadwell commented 5 years ago

Both complaints have the same root cause: that the spacing of the top-level menus is determined according to the contents of the heading (INTERMEDIA, PLAYS, etc.), and so when the drop-down menu items have text that is wider than the heading, (e.g., TOOLS OF ANALYSIS, NOH AS INTERMEDIA under INTERMEDIA), it causes an overlap with the next heading, or runs off the right-hand side of the page. So one possible fix would be to have the parent headings inherit the width of their widest child, which hopefully(?) would look OK.

simonwiles commented 5 years ago

Hmm, yeah, that could work for the overlapping issue you described -- might be worth looking at. It's a quite different issue from tooltips flowing off-screen, but it may mitigate or completely alleviate the concern I described too.

broadwell commented 5 years ago

This is only really an issue on L2, and can be addressed by adding 1.25rem of right-side padding to header__nav. The more general problem of overlap between expanded menu items is discussed in #484.

simonwiles commented 5 years ago

Closed by #493.