sul-cidr / noh

Noh as Intermedia
http://noh.stanford.edu/
MIT License
4 stars 2 forks source link

Rejig video event handlers #516

Closed simonwiles closed 5 years ago

simonwiles commented 5 years ago

This is essentially just a cull of unneeded code, event handlers, action creators, and reducers. The TimelineIndicator on Level 1 continues to function just the same without all of these, because their combined function was only to trigger a slightly different way of calculating the position of the indicator. In fact, both of the previous methods were far more expensive than necessary, so the second commit refactors that behaviour a little, and does away with about ⅔ of the code from that component (while leaving as much as possible intact). Less code means less testing too, so now redundant or irrelevant tests have been removed.