sul-cidr / noh

Noh as Intermedia
http://noh.stanford.edu/
MIT License
4 stars 2 forks source link

Enable pop-out video links in narrative text #544

Closed simonwiles closed 4 years ago

simonwiles commented 4 years ago

So it turns out that the interweave component was stripping onclick attributes (in spite of instruction to the contrary), so this PR obfuscates them and then fixes them again once they've been injected into the DOM. This is not a terrific solution, but it seems preferable to the immediately available alternatives. (The best solution, imo, would be to dispense with interweave altogether, but that's not really on the table.)

Closes #528