search

sul-cidr / noh

Noh as Intermedia
http://noh.stanford.edu/
MIT License
4 stars 2 forks source link

Touchscreen-friendly header dropdown menus #554

Closed broadwell closed 4 years ago

broadwell commented 4 years ago

This fixes #549, but should be cleared with the PIs before merging because dropdown-on-touch menu behavior for Android requires that the menu title not be a link, so for the one menu (Elements) for which the menu title is not already linked in a sub-item, that sub-item must also be added (Elements of Noh). In any case, menu dropdown triggers that are also links are probably best avoided, design-wise. The fix for the iOS+Safari behavior was both incredibly simple and rather arcane. A preview is at https://noh-mobile.netlify.com/. It has been tested on Safari, Chrome and Firefox for iOS and Chrome and Firefox for Android.

broadwell commented 4 years ago

Thanks, @inefable! We'll definitely follow your lead on any changes to the top menu and footer contents/formatting you suggest. Glad you could verify that the touch functionality is as intended.

I'm waiting to merge this for now until we decide whether #556 (the prettier rules) can/should be merged first. If so, this update would need to be rebased, but that shouldn't be much trouble.