search

sul-cidr / noh

Noh as Intermedia
http://noh.stanford.edu/
MIT License
4 stars 2 forks source link

Only show the corner "info" icon if there's something to show #570

Closed simonwiles closed 4 years ago

simonwiles commented 4 years ago

Only show the corner "info" icon if there's something to show and don't print the link text if it's not there.

I think this should cover it. The problem is we have markup with params provided but empty (e.g. link="", see src/_includes/otsuzumi-sounds.html), but this should cover all the bases, I think.

Closes #558.

broadwell commented 4 years ago

Probably worth another ticket: the (rarely used) sub-paragraphs in the overlay are awfully dim:

Screenshot 2020-04-03 12 19 26
broadwell commented 4 years ago

And just noting for the record that all these player windows look odd on mobile devices, regardless of whether the "i" is there or not: Simulator Screen Shot - iPad (7th generation) - 2020-04-03 at 12 07 40

broadwell commented 4 years ago

Final gripes: probably we should update the wiki to codify the set of possible attributes -- title, link, paragraph[1-3].

Also, just noting that the Video container with background element probably should have identical functionality, but it's only used in two active pages at present (not counting the other two derelict pages that use it), and those instances don't have any "i" content, nor do they display an icon, so they could just be left as is.