Highlight dans when shodans are highlighted from narratives

[simonwiles]

This is intended to address #21 .

@inefable I'm a bit puzzled by

Currently, when rolling over the text on the narratives block, we add the class shodan-map__item--highlight to the individual shodans on the map. This makes it impossible to highlight the dans or the acts. We should add classes to acts and dans when rolling over the narratives in order to keep the same behavior to be consistent.

Have I misunderstood something here? What behaviour are you imagining -- i.e., what would it mean to highlight a dan or an act without highlighting the shōdans? Let me know if this PR doesn't cover it!

[broadwell]

Forgive me if this is not helpful/what @inefable had in mind, but I was thinking it would be ideal if the timeline highlighting behavior when mousing over a text section linked to a single shōdan would be the same as if that shōdan had been moused over in the timeline, except without the tooltip (the shōdan gets a dark highlight, while the other shōdan in the dan get a lighter highlight, and the dan backdrop color darkens a bit). Examples are all from Kokaji:

Then the behavior when a dan-linked text element is moused over could be the same as mousing over the top of the dan in the map -- so like in this PR, but maybe with the lighter section highlight color.

Highlighting an entire act then could be like in this PR but perhaps also with the lighter section highlight.

[simonwiles]

Yeah, I can seem some of that. Starts to complicate the logic considerably, though, for perhaps quite minor visual impact? (especially with so many subtle variations of highlight -- how fine can we split this?!)

it would be ideal if the timeline highlighting behavior when mousing over a text section linked to a single shōdan would be the same as if that shōdan had been moused over in the timeline, except without the tooltip (the shōdan gets a dark highlight, while the other shōdan in the dan get a lighter highlight, and the dan backdrop color darkens a bit).

This bit is easy enough, and I can see the argument for it (but I'll wait for @inefable to chime in).

Then the behavior when a dan-linked text element is moused over could be the same as mousing over the top of the dan in the map -- so like in this PR, but maybe with the lighter section highlight color.

Still unclear of the point of this, though -- it would require more coding and the invention of a new convention for the markup in the narrative sections, and what would the difference be compared to highlighting all the sections in a dan?

[broadwell]

I haven't looked closely at the code in a while (or ever), so if it's not straightforward just to apply the timeline mouseover styles on text section hover for the various section types, then I can see how this might involve more coding than is justified by the minor stylistic benefit.

[inefable]

It looks good! I think I agree with @simonwiles about the behavior that @broadwell proposes. Currently, we're using the attribute data-highlight-shodans to indicate which shodans will be highlighted when rolling over a dan on the narrative. I think to implement Peter's proposal we should add a new attribute like data-highlight-dans to separate the highlighting of the dan from the shodan's. Maybe it's a bit too much coding and, not being completely consistent, it's good enough.

Hope I explained myself 😅

[simonwiles]

it would be ideal if the timeline highlighting behavior when mousing over a text section linked to a single shōdan would be the same as if that shōdan had been moused over in the timeline, except without the tooltip (the shōdan gets a dark highlight, while the other shōdan in the dan get a lighter highlight, and the dan backdrop color darkens a bit).

This bit is easy enough, and I can see the argument for it (but I'll wait for @inefable to chime in).

I've added one more commit to address this, @broadwell's first point, and bring a little more consistency to the behaviour. As @inefable points out, to address the second point we'd need to introduce a new markup convention (i.e. data-highlight-dans), and I'm going to argue it's not worth the additional complexity. Please feel free to make the case if you want :)