search

sul-cidr / pianolatron

Development repository for the CIDR Pianolatron application.
https://pianolatron.stanford.edu
8 stars 4 forks source link

Tweaks #218

Closed simonwiles closed 4 months ago

simonwiles commented 5 months ago

Some more tweaks; all subject to further discussion, if desired.

broadwell commented 5 months ago

I like everything so far -- the transport button hover styling is certainly an improvement, and bringing the <ViewerMetrics> "forward" in the layout really helps. I agree that it's probably preferable for the pedal buttons to have the primary color styling, in which case the <ViewerMetrics> probably could just have the grey styling that's current applied to the buttons. And I also concur that the pedal buttons need a hover style; the only stipulation I'd add is that it should be more subtle than their actual pressed/active style, because it's possible for each button to be either pressed or not pressed when hovered, and it's important to be able to ascertain its pressed status both when it's hovered and not.