search

sul-cidr / pianolatron

Development repository for the CIDR Pianolatron application.
https://pianolatron.stanford.edu
8 stars 4 forks source link

add missing metadata property druid #222

Closed moritztim closed 4 months ago

moritztim commented 4 months ago

RollDetails attempts to access metadata.druid, which is always undefined. This leads to Similar Works By This Performer including the original work itself, because this check is essentially bypassed. https://github.com/sul-cidr/pianolatron/blob/236a9c8f97fc6b57d4a885b83190c4b22c8775cf/src/components/RollDetails.svelte#L72-L74 the druid is not contained in the metadataJson, so it needs to be added after fetching it.

netlify[bot] commented 4 months ago

Deploy Preview for pianolatron-develop ready!

Name Link
Latest commit dd8a95f141cb23048fcb84bc4c99043188ef3b22
Latest deploy log https://app.netlify.com/sites/pianolatron-develop/deploys/66729ed6f68d6c00082f6b67
Deploy Preview https://deploy-preview-222--pianolatron-develop.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

moritztim commented 4 months ago

Take zb497jz4405 as an example, it should only have one similar work. In the current version there are two, one of them being zb497jz4405 itself.

broadwell commented 4 months ago

Thanks for this, and thanks in advance for reporting any other issues you might encounter! Coincidentally, we noticed this bug earlier in the week, and there is a (slightly different) fix for it in this commit of https://github.com/sul-cidr/pianolatron/pull/221. So it should be addressed soon, one way or the other.

FYI most further changes we might make in the next couple of months should be fairly superficial and involve non-core features that are likely to be cut away from the exhibit version. But let us know if you'd like to discuss our roadmap and possible ways to synchronize our efforts.

moritztim commented 4 months ago

non-core features that are likely to be cut away from the exhibit version.

I will soon show my current version to the museum. I'll get back to you once I know exactly how the exhibit should look like and what features will be included.

possible ways to synchronize our efforts.

Tbh, I've been kinda brute forcing changes that aren't exactly scalable or configurable, but I'll make pull requests for any cherry-pickable commits that might be beneficial to the project

moritztim commented 4 months ago

https://github.com/sul-cidr/pianolatron/pull/221/files#r1647579718