sul-cidr / pianolatron

Development repository for the CIDR Pianolatron application.
https://pianolatron.stanford.edu
8 stars 4 forks source link

Searchbox Fixes #229

Closed simonwiles closed 3 months ago

simonwiles commented 3 months ago

This PR fixes the bug when a single punctuation character is entered (but please double check on Safari!), and another related to highlighting going wrong due to irregular spacing in the labels from the upstream metadata.

With respect to the initial impetus regarding the odd behaviour searching for, e.g. "stars and stripes" it wasn't so much a bug (the code was working as written) as a peculiar choice/oversight on my part when (re-)implementing the search box on the search page. Behaviour is much better and less wtf now :)

netlify[bot] commented 3 months ago

Deploy Preview for pianolatron-develop ready!

Name Link
Latest commit c52140c62d83fe04e83fc401a39356fdccb6335c
Latest deploy log https://app.netlify.com/sites/pianolatron-develop/deploys/6696bc7e6c7d880008b630c7
Deploy Preview https://deploy-preview-229--pianolatron-develop.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

simonwiles commented 3 months ago

Ahh, good catch, thanks; committed a fix.