netlify[bot]
commented
3 months ago Deploy Preview for pianolatron-develop ready!
| Name | Link |
|---|---|
| Latest commit | 81777f21900ac9464d7fa6640fc9616eeedd3648 |
| Latest deploy log | https://app.netlify.com/sites/pianolatron-develop/deploys/6696c5446fd28a00088eaa81 |
| Deploy Preview | https://deploy-preview-230--pianolatron-develop.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The MIDI and JSON data changes primarily derive from running the updated
roll-image-parsercode (which was already applied to the new and existing 88-note rolls) to the red Welte rolls as well. The main update involved finessing how end-of-track messages are written to the treble and bass tracks in the expression MIDI files; the previous method produced an occasional bug in Expression MIDI mode that would cause some or all notes in the final grand cadence to be rather anticlimactically truncated --rk796xd9697was a prime example.The other changes streamline the handling of our lone 65-note roll a bit more and indicate visually when certain roll emulation settings are disallowed by the roll type. 65-note rolls get no expression emulation treatment on the backend (via
midi2exp) or in the app, which kind of makes sense given that they have no accents or pedaling, but this also means that low-level emulation factors like acceleration and tracker hole extension also aren't applied. I briefly considered modifyingmidi2expand/or adding a minimal (by design)SixtyFiveNoteExpressionizerto the app to do this, but considering 65ers' rarity and overall fairly low interest to researchers, I think it's preferable just to continue treating our singe roll as an exception until more appear in the pipeline.