search

sul-cidr / pianolatron

Development repository for the CIDR Pianolatron application.
https://pianolatron.stanford.edu
8 stars 4 forks source link

UI for when roll emulation settings are not available #231

Closed simonwiles closed 3 months ago

simonwiles commented 3 months ago

This is marginal gains for a rare edge case, but unobjectionable I hope. The :has selector has pretty good support these days, but the use here will just degrade acceptably where it's not available.

netlify[bot] commented 3 months ago

Deploy Preview for pianolatron-develop ready!

Name Link
Latest commit fce4cc9cad2cd2c0a2912989256b18645135b399
Latest deploy log https://app.netlify.com/sites/pianolatron-develop/deploys/6696e2b9c18e5800086f7c6d
Deploy Preview https://deploy-preview-231--pianolatron-develop.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

broadwell commented 3 months ago

Yeah apparently :has is "coming soon" to an official Firefox release: https://www.mozilla.org/en-US/firefox/121.0beta/releasenotes/

simonwiles commented 3 months ago

Yeah apparently :has is "coming soon" to an official Firefox release: https://www.mozilla.org/en-US/firefox/121.0beta/releasenotes/

? I'm using Firefox 128.0 here...

:has support is decent -- I'd hesitate to use it for anything load-bearing, but for progressive enhancements / nice-to-haves, I reckon it's green lights now.

broadwell commented 3 months ago

I'm inclined to merge this now, because everything works as intended (and also to get the next a11y PR in), but I'd like for one of the next PRs to involve also converting the checkbox items under the MIDI Settings and Expression Settings menus to <fieldset><label><input> from <fieldset><div><input> so that they have the same behavior, i.e., the checkbox assumes the highlight color when the box OR the label is hovered (assuming that's desirable) and toggles when either the box or the label is clicked.

simonwiles commented 3 months ago

I'd like for one of the next PRs to involve also converting the checkbox items under the MIDI Settings and Expression Settings menus to <fieldset><label><input> from <fieldset><div><input> so that they have the same behavior

Yeah, that's a good point, this has introduced an inconsistency there. It's not exactly like the UI is otherwise free of inconsistencies, of course, but we want to trend in a positive direction, not the other way around, sorry :) I'll take care of that tomorrow 👍️.

broadwell commented 3 months ago

? I'm using Firefox 128.0 here...

Turns out my FF install was moved to the ESR track when the OS aged out, and I guess it doesn't automagically switch back to the non-ESR update channel upon a subsequent OS update. Time to reinstall...

simonwiles commented 3 months ago

Huh, that's a bit too clever for my taste, but I suppose it makes some sense. Coincidentally (ironically?) FF 128, just released, is the new ESR version...

broadwell commented 3 months ago

Huh, that's a bit too clever for my taste, but I suppose it makes some sense. Coincidentally (ironically?) FF 128, just released, is the new ESR version...

Yeah it's available, but my FF Mac OS install was in no hurry to leave 115.13.0esr. Anyway I've reinstalled from the main channel and now have full use of :has.