show the object as accessioned if it has an accesioned milestone

sul-dlss-deprecated / dor-services

Common services, models, and utility classes used by the Stanford Digital Repository (DOR == Digital Object Registry)

Other

8 stars 4 forks source link

show the object as accessioned if it has an accesioned milestone #646

Closed peetucket closed 5 years ago

peetucket commented 5 years ago

...even if it is not the last timestamp

This gets around the issue where we show a status to users in Argo that is incorrect if an earlier workflow step with an earlier lifecycle is manually repeated or triggered during an object remediation. The idea is that if an object has a current lifecycle of accessioned (current being the latest version), it should be considered accessioned regardless of timestamps.

coveralls commented 5 years ago

Coverage increased (+0.006%) to 91.272% when pulling 922389c6e4781337ab100ae6fd85f221c2fc7e4e on update-status-computation into 2d2480180a69a645c59a9d92aa279671d62e9e6d on 7-2-stable.

jcoyne commented 5 years ago

Why is this on 7-2-stable and not on master? I'd expect a change in master first and then a backport to 7-x (probably 7.3) if necessary

peetucket commented 5 years ago

fair enough, same change on master: https://github.com/sul-dlss/dor-services/pull/648