ticket suggests adding a private helper method project_tag?, but the tag splitting that's already there makes this feel a little unnecessary. even as groundwork for #1006, which #1004 blocks, this feels a little unnecessary given what's already there
ticket suggests writing "project tags to a new Solr field, project_tag_ssim"... but afaict, we are already indexing project tags that way? i see it in the DIA solr doc building code and unit tests, and in the Solr admin schema view, and in use in the argo code. so i just left that as-is.
per the ticket, i only indexed exploded_project_tag, but it'd be easy to do a similar sort of indexing for the other special tag, Registered By/registered_by.
How was this change tested? 🤨
[x] unit tests/CI
[x] deploy to stage or QA
[x] examined solr doc for a QA object with project tags, and one without, confirmed that project and exploded project tag fields looked fine on former, and that they weren't present on latter
âš¡ âš If this change has cross service impact, run integration tests that exercise indexing (e.g. searches in Argo for newly created/updated items, access_indexing_spec) and/or test in [stage|qa] environment, in addition to specs. âš¡
Why was this change made? 🤔
fixes #1004
deviations from the suggestions in the ticket
project_tag?, but the tag splitting that's already there makes this feel a little unnecessary. even as groundwork for #1006, which #1004 blocks, this feels a little unnecessary given what's already thereproject_tag_ssim"... but afaict, we are already indexing project tags that way? i see it in the DIA solr doc building code and unit tests, and in the Solr admin schema view, and in use in the argo code. so i just left that as-is.per the ticket, i only indexed
exploded_project_tag, but it'd be easy to do a similar sort of indexing for the other special tag,Registered By/registered_by.How was this change tested? 🤨
âš¡ âš If this change has cross service impact, run integration tests that exercise indexing (e.g. searches in Argo for newly created/updated items, access_indexing_spec) and/or test in [stage|qa] environment, in addition to specs. âš¡