search

sul-dlss-deprecated / dor_indexing_app

An indexing API for Stanford's Digital Object Repository
https://sul-dlss-deprecated.github.io/dor_indexing_app/
Apache License 2.0
0 stars 2 forks source link

Cache collections #1060

Closed justinlittman closed 10 months ago

justinlittman commented 10 months ago

Why was this change made? 🤔

To reduce the load on DSA with redundant calls.

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, run integration tests that exercise indexing (e.g. searches in Argo for newly created/updated items, access_indexing_spec) and/or test in [stage|qa] environment, in addition to specs. âš¡

Unit

edsu commented 10 months ago

So this cache will live as long as the process lives?

justinlittman commented 10 months ago

@edsu Yes. That seems safe enough. If it proves problematic, we can come up with a more sophisticated strategy.

edsu commented 10 months ago

I guess I just worry about how we will notice that it's become problematic.

justinlittman commented 10 months ago

For what it is worth, we do this sort of caching for APOs in other parts of the code.

edsu commented 10 months ago

Do APOs change at roughly the same rate as Collections?