search

sul-dlss-deprecated / dor_indexing_app

An indexing API for Stanford's Digital Object Repository
https://sul-dlss-deprecated.github.io/dor_indexing_app/
Apache License 2.0
0 stars 2 forks source link

index dois and orcidids #986

Closed peetucket closed 1 year ago

peetucket commented 1 year ago

Why was this change made? 🤔

Part of https://github.com/sul-dlss/argo/issues/4096

This will index DOIs (for items) and ORCIDIDs (for contributors) into solr.

There will then be a separate Argo PR to add the appropriate facet (e.g. 'Identifiers', which then has multiple values, searching for any objects where the DOI/ORCID fields are not null).

HOLD pending test in QA or stage

How was this change tested? 🤨

New tests

peetucket commented 1 year ago

This class is already too large and the ORCID handling adds enough code, that I would request that it be separated out into its own class. (I think we've been using the convention of calling those builders.)

(No issue with the code, though.)

Abstracted ORCID code into a new class (using same pattern as AuthorBuilder) to reduce size of descriptive indexer class.