search

sul-dlss-deprecated / dor_indexing_app

An indexing API for Stanford's Digital Object Repository
https://sul-dlss-deprecated.github.io/dor_indexing_app/
Apache License 2.0
0 stars 2 forks source link

deal with a different orcid format #989

Closed peetucket closed 1 year ago

peetucket commented 1 year ago

Why was this change made? 🤔

This HB alert was triggered when trying to index records with a different ORCID format in the descriptive cocina than we were expecting. This allows us to deal with it.

see https://app.honeybadger.io/projects/49898/faults/99952126 and https://argo-prod-02.stanford.edu/view/druid:gf852zt8324 for the example record

How was this change tested? 🤨

Updated spec to include the alternate format.

peetucket commented 1 year ago

@arcadiafalcone just FYI, when deploying a change to indexing code to add ORCIDs for contributors in descriptive metadata, we hit a druid that had a slightly different format than the one we are using for H2 records. You can see it here: https://argo-prod-02.stanford.edu/view/druid:gf852zt8324

This completed PR for dor_indexing_app allows our indexing code to deal with this difference and work in both cases, but not sure if it was expected or not and if there will be other records like this (or possibly even different from H2 and this one).