search

sul-dlss-deprecated / eloader-pkg-admin

Electronic Resource Package Management Interface for Symphony
Apache License 2.0
0 stars 1 forks source link

Url exclude #29

Closed jgreben closed 8 years ago

jgreben commented 8 years ago

Corrects the test syntax for PUT and DESTROY. Make db seed data and Re-enables the coveralls lint.

jgreben commented 8 years ago

@shelleydoljack @dlrueda I won't use this branch anymore after this pull request. All the tests are passing now!

dlrueda commented 8 years ago

Do all the localhost:3000/url_exclusions actions work: create a new one, edit, destroy? Call me paranoid but I want to know if the actual web site works, beyond the rake tests.

jgreben commented 8 years ago

Ok this fixes the destroy method. Who knew that you needed javascript fir this to work...

dlrueda commented 8 years ago

Crazy. And edit works too? That one was broken also, and I imagine having javascript probably fixes this as well, but can you double-check? Sorry, so paranoid (but I was right last time....)

jgreben commented 8 years ago

Paranoid!

dlrueda commented 8 years ago

Absolutely!

jgreben commented 8 years ago

It's all good to go! Edit too. 👍

dlrueda commented 8 years ago

Groovy!