sul-dlss-deprecated / hydrox

DEPRECATED: Hydrox was an experiment to use Hyrax to replace Hydrus as the web-based deposit interface to the Stanford Digital Repository
0 stars 0 forks source link

Set login referrer to /dashboard #78

Closed aaron-collier closed 6 years ago

aaron-collier commented 6 years ago

This sets the referrer to /dashboard on shibboleth login for the proper return end-point.

mjgiarlo commented 6 years ago

I believe Devise has some mechanics we can use for this: https://github.com/plataformatec/devise/wiki/How-To:-redirect-to-a-specific-page-on-successful-sign-in

aaron-collier commented 6 years ago

@mjgiarlo It does. This MAY just be the first step here, as it's mirroring what was done in SearchWorks, in order to get this working. Ideally, yeah, the devise mechanism is coming ;-)

mjgiarlo commented 6 years ago

Ah, that's good to know re: SW. OK. Do we need a ticket for the follow-up work to use Devise instead of a view override? Approving for now.

aaron-collier commented 6 years ago

@mjgiarlo I opened a terse issue, please feel free to use your github-issue-fu to clean that up :-)

jcoyne commented 6 years ago

+1 to using after_sign_in_path_for rather than overriding a template.