search

sul-dlss-deprecated / iiifManifestLayouts

Other
10 stars 5 forks source link

Slim down memory usage #111

Open iangilman opened 8 years ago

iangilman commented 8 years ago

Switch back to LegacyTileSource so we get lazy loading and auto purging. See:

https://github.com/sul-dlss/iiifManifestLayouts/pull/108#issuecomment-167630511

aeschylus commented 8 years ago

:+1:

iangilman commented 8 years ago

Hmm...I'm running the example on master right now, and it is in fact opening a bunch of info.json files as soon as it starts, so I guess there's an issue there as well...it should only be opening the one for the selected image. @nein09 Can you take a look?

iangilman commented 8 years ago

Now that #112 has been merged, it would be interesting to see how we're doing on the memory usage.

nein09 commented 8 years ago

The Osborn example in master seems to be topping out around 1.2 GB of memory in Firefox right now, which is a huge improvement compared to the 8 GB it was trying to use on my machine.

nein09 commented 8 years ago

Hmm, I just got it up to around 3 GB by running that for a while...

It's definitely an improvement, but is it enough? Is this likely to be the largest manifest anyone ever sees, or is it an average size?

aeschylus commented 8 years ago

see https://github.com/sul-dlss/iiifManifestLayouts/issues/97#issuecomment-171033819

aeschylus commented 8 years ago

https://github.com/sul-dlss/iiifManifestLayouts/issues/97#issuecomment-171080571