search

sul-dlss-deprecated / iiifManifestLayouts

Other
10 stars 5 forks source link

Proposal to simplify build process #56

Closed mejackreed closed 9 years ago

mejackreed commented 9 years ago

Rather than copying the built file and including code changes 3 times, reduce the complexity and only include twice :)

Thoughts?

I'd like to figure out a way to only include it once if possible... is there a way to browserify from an html file?

aeschylus commented 9 years ago

I know it seems convoluted, but this was done because when we do eventually publish a build, it will be that example folder, so it needs to stand alone. If the "download zipfile" kind of developer tries to use that, it will be confusing to them. In general I'm trying to avoid relative paths that include the whole project.

mejackreed commented 9 years ago

Ok, I can understand that. I wonder is there a way to do that on every release, rather than every line change? That might simplify the git history?

aeschylus commented 9 years ago

Yeah, that would be nice. Perhaps they should all be unversioned, and we can write a task that will properly include them in the release. For now I will remove them from git. I need to test to make sure the build process handles them correctly despite them being removed (creates the dist folder, etc.)