search

sul-dlss-deprecated / iiifManifestLayouts

Other
10 stars 5 forks source link

Use d3.timer instead of setTimeout to potentially optimize animation … #89

Closed mejackreed closed 9 years ago

mejackreed commented 9 years ago

…frames

aeschylus commented 9 years ago

Did you notice a difference? This would probably be an improvement, but I would have a look at the d3 timer source to make sure the delay parameter is not itself implemented using a setTimeout.

aeschylus commented 9 years ago

https://github.com/mbostock/d3/blob/5b981a18db32938206b3579248c47205ecc94123/src/event/timer.js#L25

mejackreed commented 9 years ago

Reading through the documentation though here:

The timer queue is also smart about using setTimeout when there is a long delay before the next scheduled event.

https://github.com/mbostock/d3/wiki/Transitions#timers