search

sul-dlss-deprecated / iiifManifestLayouts

Other
10 stars 5 forks source link

[In Progress]: Make filmstrip for detail layout #96

Closed nein09 closed 8 years ago

nein09 commented 8 years ago

This is a step toward the solution for https://github.com/sul-dlss/iiifManifestLayouts/issues/9

iangilman commented 8 years ago

I like Lines being a real object.

What's the bug you introduced?

nein09 commented 8 years ago

The bug is that left pages at the end of a line have their right pages on the next line, in the grid. It's probably a case that I took out erroneously; I'm working on it now.

nein09 commented 8 years ago

My thinking is that by extracting Lines in this way, it sets me up to add a function that is something like addItemsAllOnOneLine() that makes a filmstrip.

nein09 commented 8 years ago

Fixed- I wasn't calculating the line length correctly for a paged layout.

nein09 commented 8 years ago

Closing because #94 has been merged into master; re-opening as a PR on master.