search

sul-dlss-deprecated / ld4p-tracer-bullets

A place to keep functional specs and documents for Stanford's ld4p tracer bullets
Other
0 stars 1 forks source link

pom.xml - remove compiler plugin at top level #92

Closed dazza-codes closed 7 years ago

dazza-codes commented 7 years ago

The parent project has no code to compile, so removing the compiler plugin at this level. The compiler plugin is defined in the converter module, where it belongs.

This commit is a prelude to using a branch that will compile for java 7, because the code is java 7 compatible and it can compile on java 7 (this can be verified using the java-7 branch). To enable this option to build for java-7, the compiler config in the converter module needs to be modified. When it is modified, there are conflicts with the parent compiler plugin. As it turns out, we don't need the parent compiler plugin at all, so let's remove it.

(Note, this is not a proposal or recommendation to use java 7. This PR is only removing an extraneous/duplicate compiler plugin from the parent pom.xml file.)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 46.154% when pulling a0888521c67abd986abb564e4c7b96796effa910 on no-compiler-for-root-project into 46c5589383d4aefab94660cc8e357e84c939ec55 on master.