sul-dlss-deprecated / rialto-webapp

The web front end of the RIALTO project
4 stars 0 forks source link

coverage for both rspec and jest tests #414

Closed ndushay closed 4 years ago

ndushay commented 4 years ago

Why was this change made?

so codeclimate coverage would reflect both frontend (javascript/vue) tests and backend (ruby) tests.

Fixes #391

note that this pr sets up the plumbing; coverage configurations may still be needed.

NOTE: easier to review with "split" view:

image

Was the documentation (README, wiki, ...) updated?

n/a

ndushay commented 4 years ago

Note that last status won't be reported because I reverted a commit, so the sha being sent to codeclimate is the same as a previous one ... and it won't do that.

here's the proof it works:

https://app.circleci.com/github/sul-dlss/rialto-webapp/pipelines/89ba26e8-8c19-41f9-bd4c-1733313d3dfc/workflows/4c782817-fb61-4e9e-ac6f-b8270f449a7c